diff options
| author | Alon Levy <alon@pobox.com> | 2014-11-29 22:02:36 +0200 |
|---|---|---|
| committer | Alon Levy <alon@pobox.com> | 2014-11-29 22:30:22 +0200 |
| commit | 8f3fbee277526122b5c0e3bd882e66fac3caf0ef (patch) | |
| tree | 87f89e44cecbff66d8831f12c68bcd0abea3c4d3 /src | |
| parent | 87cb13da2cf203ad504904c9f6983297c531bd3e (diff) | |
textanalysis.ui: use switches and make signals fire after processing event
Diffstat (limited to 'src')
| -rw-r--r-- | src/textanalysis.ui.js | 59 |
1 files changed, 30 insertions, 29 deletions
diff --git a/src/textanalysis.ui.js b/src/textanalysis.ui.js index 10007bd7..15d3d2e2 100644 --- a/src/textanalysis.ui.js +++ b/src/textanalysis.ui.js @@ -117,35 +117,34 @@ return { }); $(document).keypress(function(e) { - signal.signal(consts.KEYSTROKES, [{where: consts.KEYSTROKE_WHERE_DOCUMENT, keys: [e.keyCode]}]); - if (e.keyCode == 9) {//TAB + var ret = undefined; + switch (e.keyCode) { + case 9: //TAB e.preventDefault(); changeType(e.shiftKey ? "up" : "down", textanalysis.lastnode()); - return false; - } - - if (e.keyCode == 37) {//UP - $('html, body').scrollLeft(0); - } - if (e.keyCode == 39) {//DOWN - $('html, body').scrollLeft(0); - } - - if (e.keyCode == 38) {//UP + ret = false; + break; + case 37: //UP + $('html, body').scrollLeft(0); + break; + case 39: //DOWN + $('html, body').scrollLeft(0); + break; + case 38: //UP suggestionChange = true; - } - if (e.keyCode == 40) {//DOWN + break; + case 40: //DOWN suggestionChange = true; + break; } - - if (e.keyCode == 9) {//TAB - return false; - } + signal.signal(consts.KEYSTROKES, [{where: consts.KEYSTROKE_WHERE_DOCUMENT, keys: [e.keyCode]}]); + return ret; }); element.keypress(function(e) { - signal.signal(consts.KEYSTROKES, [{where: consts.KEYSTROKE_WHERE_TEXTANALYSIS, keys:[e.which]}]); - if (e.which == 13) { + var ret = undefined; + switch (e.which) { + case 13: if(!suggestionChange) { text = element.val(); element.val(""); @@ -153,19 +152,21 @@ return { } else { suggestionChange = false; } - return false; - } - - if (e.which == 37) {//RIGHT + ret = false; + break; + case 37: //RIGHT $('body').scrollLeft(0); e.stopPropagation(); - return false; - } - if (e.which == 39) { //LEFT + ret = false; + break; + case 39: //LEFT $('body').scrollLeft(0); e.stopPropagation(); - return false; + ret = false; + break; } + signal.signal(consts.KEYSTROKES, [{where: consts.KEYSTROKE_WHERE_TEXTANALYSIS, keys:[e.which]}]); + return ret; }); if ('oninput' in document.documentElement) { |
