From 1cd350f16c2a686e96a6a87113ac026fd4440bd8 Mon Sep 17 00:00:00 2001 From: Alon Levy Date: Tue, 11 Nov 2014 11:21:07 +0200 Subject: graph: addLinkByName: end fix of unchought exception on missing id --- scripts/model/graph.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'scripts/model/graph.js') diff --git a/scripts/model/graph.js b/scripts/model/graph.js index e0881155..665b0a87 100644 --- a/scripts/model/graph.js +++ b/scripts/model/graph.js @@ -245,11 +245,14 @@ function Graph(el) { } this.addLinkByName = function(sourceName, targetName, name, state, drop_conjugator_links) { - var sourceId = findNodeByName(sourceName, null).id; - var targetId = findNodeByName(targetName, null).id; - - if (sourceId === undefined || targetId === undefined) { - console.log('error: cannot add link between names : ' + sourceName + ', ' + targetName); + var source = findNodeByName(sourceName, null), + target = findNodeByName(targetName, null), + sourceId = source ? source.id : null, + targetId = target ? target.id : null; + + if (sourceId === null || targetId === null) { + console.log('error: link of missing nodes: ' + sourceName + ' (' + sourceId + ') -> ' + + targetName + ' (' + targetId + ')'); return; } this.addLink(sourceId, targetId, name, state, drop_conjugator_links); -- cgit v1.3.1