summaryrefslogtreecommitdiff
path: root/src/model
diff options
context:
space:
mode:
authorLV-426 <lv-426@taproot.org.il>2014-12-10 15:30:16 +0200
committerAlon Levy <alon@pobox.com>2014-12-16 10:59:14 +0200
commit0b895bde1215f981a920b596a4b7c3ad84a95429 (patch)
tree0ec9da51161d56a5e193e205989b5b671e82d6d6 /src/model
parent2f302321018f8a4ea504e5cc4bdb7e06441b44bd (diff)
create_node/link_from_spec: assertions
Diffstat (limited to 'src/model')
-rw-r--r--src/model/core.js25
1 files changed, 12 insertions, 13 deletions
diff --git a/src/model/core.js b/src/model/core.js
index cb5dca59..d57a9f72 100644
--- a/src/model/core.js
+++ b/src/model/core.js
@@ -65,11 +65,8 @@ define(['util'], function(util) {
__set_obj_id(ret, node_spec.id);
}
- // name
- if (undefined == node_spec.name) {
- console.debug('create_node_from_spec: undefined name, falling back to \"\"');
- node_spec.name = "";
- }
+ util.assert(undefined != node_spec.name, 'create_node_from_spec: name missing');
+
ret.name = node_spec.name;
// type
@@ -140,16 +137,18 @@ define(['util'], function(util) {
}
function create_link_from_spec(src, dst, link_spec) {
- if (undefined == src) {
- console.error('create_link_from_spec: undefined: src');
- return null;
- }
- if (undefined == dst) {
- console.error('create_link_from_spec: undefined: dst');
- return null;
+ var ret = new Link();
+
+ if (undefined != link_spec.id) {
+ // reuse id if present
+ __set_obj_id(ret, link_spec.id);
}
- var ret = new Link();
+ util.assert(undefined != src, 'create_link_from_spec: src missing');
+ util.assert(undefined != dst, 'create_link_from_spec: dst missing');
+ util.assert(undefined != src.id, 'create_link_from_spec: src missing id');
+ util.assert(undefined != dst.id, 'create_link_from_spec: dst missing id');
+
ret.__src = src;
ret.__dst = dst;
ret.__type = 'textual_link';